Study changes to t/op/*.t (1 of 12)

[jkeenan]

In this ticket we will study our progress in pursuit of Objective 2, "strict-by-default", for the following files in the Perl core distribution:

t/op/64bitint.t
t/op/alarm.t
t/op/anonconst.t
t/op/anonsub.t
t/op/append.t
t/op/array.t
t/op/attrs.t
t/op/auto.t
t/op/avhv.t
t/op/bless.t

These files should be evaluated in light of the guidelines presented on this wiki page. Please post the summary of your findings in a single comment in this issue.

First-time contributors: (1) Please post a comment to this ticket indicating you are working on it. That will enable us to assign the ticket to you. (GitHub won't let us do that until it already thinks you're part of the project.) (2) You should subscribe to this repository so that you get email updates.

Thank you for helping to improve the Perl programming language.

[brainbuz]

I'll take this issue.

[brainbuz]

I've reviewed these test files and they are all passing on a Linux system.

file	pass	strictures not globally specified	reviewed diffs
t/op/64bitint.t	x	x	x
t/op/alarm.t	x	x	x	has conditional for platforms. Also a todo was added which passes
t/op/anonconst.t	x	x	x
t/op/anonsub.t	x	needs commit	x	stricture still in upstream, passes with removal.
t/op/append.t	x	x	x
t/op/array.t	x	x	x	a lot of changes with selective strict and declations of variables.
t/op/attrs.t	x	x	x	has tests that turn strict on or off
t/op/auto.t	x	x	x
t/op/avhv.t	x	x	x
t/op/bless.t	x	x	x

[jkeenan]

I've reviewed these test files and they are all passing on a Linux system.

Thanks. Were there any locations where our adaptations to the files to get them to run under strict-by-default seemed problematic?

[brainbuz]

I've redone the assignment and updated my results. I recommend one change to remove use strict at line 7 of anonsub. should I submit a PR?
That test also has a todo failure which may be quite old.

[jkeenan]

On 9/16/20 2:58 PM, John Karr wrote: I've redone the assignment and updated my results. I recommend one change to remove use strict at line 7 of anonsub. should I submit a PR?

Yes.

That test also has a todo failure which may be quite old.

That would have to be taken up https://github.com/Perl/perl5/issues. It still fails for me on Linux.

[jkeenan]

Good work; @atoomic just merged your p.r. As of commit 6a85d9e you are now a Perl author. Closing this ticket.

Thank you very much.
Jim Keenan