Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/strict.t: Adapt to warnings-by-default #321

Closed
jkeenan opened this issue Oct 27, 2020 · 1 comment
Closed

lib/strict.t: Adapt to warnings-by-default #321

jkeenan opened this issue Oct 27, 2020 · 1 comment
Labels
warnings-by-default

Comments

@jkeenan
Copy link
Collaborator

jkeenan commented Oct 27, 2020

In this ticket we will track our progress on implementing Objective 3, warnings-by-default, for lib/strict.t in the core distribution. See that ticket for guidance on addressing warnings.

This file spews so many warnings that it will be useful to treat it separately from the overall ticket for the `lib' directory, #306.

Current output for this file can be seen here.

Acceptance Criteria: All tests for this subdirectory PASS; no tests emit warnings.
@jkeenan
Copy link
Collaborator Author

jkeenan commented Dec 18, 2020

We don't need to keep a ticket open for just this file, as I have made the necessary changes for lib/strict.t as part of pull request #348.

@jkeenan jkeenan closed this as completed Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
warnings-by-default
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jkeenan