Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow scheme to be overridden #37

Open
timlegge opened this issue Sep 2, 2024 · 1 comment
Open

allow scheme to be overridden #37

timlegge opened this issue Sep 2, 2024 · 1 comment
Assignees

Comments

@timlegge
Copy link
Collaborator

timlegge commented Sep 2, 2024

PR #34 addressed part of #32. This would address the remaining portion.

./lib/Module/Signature.pm

291		sub _keyserver {
		    my $version = shift;
		    my $scheme = 'x-hkp';
		    $scheme = 'hkp' if $version ge '1.2.0';

		    return "$scheme://$KeyServer:$KeyServerPort";
		}

regardless of keyserver, scheme is set to "hkp://"

so on exec, "--keyserver=hkp://" is generated/sent,

@pgnd suggests something like:

To support newer servers, and differing schemes can "$KeyServerScheme" be added as ENV VAR; perhaps,

$KeyServerScheme = $ENV{MODULE_SIGNATURE_KEYSERVER_SCHEME} || 'hkps';

@timlegge
Copy link
Collaborator Author

Will also close RT#100016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant