Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(goal_planner): introduce bezier based pullover for bus stop area #10005

Closed
wants to merge 17 commits into from

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Jan 22, 2025

Description

if use_bus_stop_area = true, bezier_planner starts working and feasible path is found (if false, only shift planner works and no candidate paths are generated)

before-2025-01-22_16.56.03.mp4
before-2025-01-22_17.11.52.mp4

launcher: autowarefoundation/autoware_launch#1308

Related links

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Jan 22, 2025
Copy link

github-actions bot commented Jan 22, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@soblin soblin changed the title Feat/bezier pullover bus feat(goal_planner): introduce bezier based pullover for bus stop area Jan 22, 2025
@github-actions github-actions bot removed the component:common Common packages from the autoware-common repository. (auto-assigned) label Jan 22, 2025
@soblin soblin force-pushed the feat/bezier-pullover-bus branch 2 times, most recently from 68e55c7 to f379bd8 Compare January 22, 2025 08:33
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
@soblin soblin force-pushed the feat/bezier-pullover-bus branch from f379bd8 to 20eb08d Compare January 23, 2025 01:32
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
}
}

void LaneParkingPlanner::shift_planning_helper(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this helper is not only for shift. geometric_pull_over is also called in this helper

for (const auto & planner : pull_over_planners_) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in bc8f304

Signed-off-by: Mamoru Sobue <[email protected]>
@@ -130,6 +130,10 @@
neighbor_radius: 8.0
margin: 1.0

bezier_parking:
pull_over_azimuth_threshold: 0.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits:

when I hear azimuth in autoware I image

/**
 * @brief calculate azimuth angle of two points.
 * @details This function returns the azimuth angle of the position of the two input points
 *          with respect to the origin of their coordinate system.
 *          If x and y of the two points are the same, the calculation result will be unstable.
 * @param p_from source point
 * @param p_to target point
 * @return -pi < azimuth angle < pi.
 */
double calcAzimuthAngle(
  const geometry_msgs::msg::Point & p_from, const geometry_msgs::msg::Point & p_to)
{
  const double dx = p_to.x - p_from.x;
  const double dy = p_to.y - p_from.y;
  return std::atan2(dy, dx);
}

but here azimuth is two pose orientaion diff.
add explanation or rename it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in bc8f304

Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
@kosuke55
Copy link
Contributor

kosuke55 commented Jan 27, 2025

todo

  • update the goal searcher so that the condition for searching goals within the bus stop area is use_bus_stop_area && goal is within the bus stop area
  • introduce a trigger_thread_flag for generating paths in advance.

Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants