New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Data.Char.Unicode isDigit dependency #6

Open

paulyoung opened this issue Feb 26, 2018 · 0 comments

Contributor

paulyoung commented Feb 26, 2018

@natefaubion pointed out this dependency. We should probably just inline this:

-- | Selects ASCII digits, i.e. `0..9`.
isDigit :: Char -> Boolean
isDigit c = let diff = (toCharCode c - toCharCode '0')
            in diff <= 9 && diff >= 0

https://github.com/purescript-contrib/purescript-unicode/blob/de173a882515bad669949a1dceccb49c9f96d48a/src/Data/Char/Unicode.purs#L366-L369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment