You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When putting the get_config function in the same module as the Pipeline and PipelineConfig, we got a RegistryError, saying that the type_hint had already been registered. I'm not sure why this was triggered in this situation, but there may be an easy way around it. Currently, we check that the type_hint hasn't been registered before (to catch mistakes where someone uses the same type_hint twice). This is good, but it leads to an error if the module gets imported twice. Hopefully we can avoid that problem if we only raise an error if the type hint and value (ie. the Config class) have already been registered.
When putting the
get_config
function in the same module as thePipeline
andPipelineConfig
, we got aRegistryError
, saying that the type_hint had already been registered. I'm not sure why this was triggered in this situation, but there may be an easy way around it. Currently, we check that the type_hint hasn't been registered before (to catch mistakes where someone uses the same type_hint twice). This is good, but it leads to an error if the module gets imported twice. Hopefully we can avoid that problem if we only raise an error if the type hint and value (ie. the Config class) have already been registered.Thanks to @echeipesh for this idea.
The text was updated successfully, but these errors were encountered: