Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get off-chain group admin info using the API #460

Closed
vplasencia opened this issue Mar 29, 2024 · 0 comments · Fixed by #461
Closed

Fix get off-chain group admin info using the API #460

vplasencia opened this issue Mar 29, 2024 · 0 comments · Fixed by #461
Assignees
@vplasencia
Labels
bug 🐛 Something isn't working
Milestone
4. Dione

Comments

@vplasencia
Copy link
Member

Description

With the latest updates (#446), you can get the admin api key from off-chain groups. This issue needs to be fixed so that users cannot access other people's groups.
@vplasencia vplasencia added the bug 🐛 Something isn't working label Mar 29, 2024
@vplasencia vplasencia added this to the 4. Dione milestone Mar 29, 2024
@vplasencia vplasencia self-assigned this Mar 29, 2024
vplasencia added a commit that referenced this issue Mar 29, 2024
@vplasencia
fix: prevent access to admin info from outside the dashboard
ada9610 
Add @UseGuards to prevent access to admin info from outside the dashboard, exclude the admin
controller endpoints from the api docs and remove all the api requests related to the admins in the
api sdk.

re #460
vplasencia added a commit that referenced this issue Mar 30, 2024
@vplasencia
fix: remove the creation of an admin in the dashboard app
fa7cecc 
The admin must be created in the Bandada backend.

re #460
@vplasencia vplasencia mentioned this issue Mar 30, 2024
Merged
2 tasks
@vplasencia vplasencia linked a pull request Mar 30, 2024 that will close this issue
Fix bugs and refactor code #461
Merged
2 tasks
@vplasencia vplasencia moved this to ✅ Done in Bandada Board Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vplasencia vplasencia

Labels
bug 🐛 Something isn't working
Projects
Bandada Board
Status: ✅ Done
Milestone
4. Dione
Development

Successfully merging a pull request may close this issue.

Fix bugs and refactor code bandada-infra/bandada
1 participant
@vplasencia