Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starlark flags are omitted from BEP "explicit command line" #23514

Open
tpudlik opened this issue Sep 4, 2024 · 2 comments
Open

Starlark flags are omitted from BEP "explicit command line" #23514

tpudlik opened this issue Sep 4, 2024 · 2 comments
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Configurability platforms, toolchains, cquery, select(), config transitions type: bug

Comments

@tpudlik
Copy link
Contributor

tpudlik commented Sep 4, 2024

Description of the bug:

Starlark flags (like label_flag) are omitted from the explicitCmdLine provided via BEP, even when they are in fact explicitly provided by the user on the command line.

This is inconvenient because the user should be able to copy-paste the explicit command line to reproduce the build, but that obviously requires setting the Starlark flags, too!

See buildbuddy-io/buildbuddy#7361 for more context.

Which category does this issue belong to?

Configurability, Remote Execution

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

No response

Which operating system are you running Bazel on?

No response

What is the output of bazel info release?

8.0.0-pre.20240618.2

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse HEAD ?

No response

If this is a regression, please try to identify the Bazel commit where the bug was introduced with bazelisk --bisect.

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@github-actions github-actions bot added team-Configurability platforms, toolchains, cquery, select(), config transitions team-Remote-Exec Issues and PRs for the Execution (Remote) team labels Sep 4, 2024
@joeleba joeleba removed the team-Remote-Exec Issues and PRs for the Execution (Remote) team label Sep 10, 2024
@meisterT
Copy link
Member

cc @michaeledgar

@aranguyen
Copy link
Contributor

@fmeum I'm triaging the issues for the team and notice you mentioned a potential fix is this still in your plan? I'm aware you also mentioned the fix is more involved than expected

@aranguyen aranguyen added P3 We're not considering working on this, but happy to review a PR. (No assignee) P2 We'll consider working on this in future. (Assignee optional) and removed untriaged P3 We're not considering working on this, but happy to review a PR. (No assignee) labels Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Configurability platforms, toolchains, cquery, select(), config transitions type: bug
Projects
None yet
Development

No branches or pull requests

7 participants