fix: Unexpected default rack.session #1093
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some rack applications fail when the `rack.session` is already initialized, but with an unexpected value. For example, in a Rails API-only application, unexpected behavior is triggered when a `rack.session` is present. This commit changes webmock, not to set a `rack.session` at all, similar to how web servers do not set a session. The application or a middleware sets them up if needed. Fixes bblimke#985
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some rack applications fail when the
rack.sessionis already initialized, but with an unexpected value. For example, in a Rails API-only application, unexpected behavior is triggered when arack.sessionis present.This PR changes webmock, not to set a
rack.sessionat all, similar to how web servers do not set a session. The application or a middleware sets them up if needed.Fixes #985