Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File watcher is not work perfectly with symlink #1946

Open
invzhi opened this issue Jan 9, 2025 · 0 comments
Open

File watcher is not work perfectly with symlink #1946

invzhi opened this issue Jan 9, 2025 · 0 comments

Comments

@invzhi
Copy link

invzhi commented Jan 9, 2025

I'm using git-sync and fava with docker-compose to share the ledger with my partner.

git-sync "publishes" each sync through a worktree and a named symlink to ensure an atomic update.
image

The problem is that when I update and push the ledger for the first time after the fava docker runs, fava can catch changes. But when I update and push the ledger again, fava cannot catch changes.
This means in my situation, fava can only catch changes for the first time.

I checked the code. Maybe the cause is fava only watches the absolute path of files.

files_set = {p.absolute() for p in files if p.exists()}
folders_set = {p.absolute() for p in folders if p.is_dir()}

BTW, I tried --poll-watcher option. It works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant