Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use alternative to rack-jekyll to run accessibility tests #25

Closed
phrdang opened this issue Jun 19, 2024 · 2 comments
Closed

Use alternative to rack-jekyll to run accessibility tests #25

phrdang opened this issue Jun 19, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@phrdang
Copy link
Member

phrdang commented Jun 19, 2024

See commit message here: e1efa4e

See also #17

@phrdang phrdang added the enhancement New feature or request label Jun 19, 2024
@cycomachead
Copy link
Contributor

In another non-Jekyll static app I used Rack::File directly. It was a fairly simple change, but rack::file is also throwing future deprecation warnings.

We do need a hook to ensure the Jekyll site is fully built before starting the test run. We could in CI just call Jekyll build and have a dev warning? I mean it's not as nice but in terms of workability it's not a huge deal.

I haven't looked at what updating rack-Jekyll would be but that honestly shouldn't be a huge dependency.

@cycomachead
Copy link
Contributor

OK, well Rack::File became Rack::Files so that wasn't too hard of a fix, but I do feel like the path mapping is a little awkward...oh well.

See #37 which was meant to just be styling but then I realized none of the CI tests were actually loading the right CSS so I went down the path of just refactoring a bunch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants