Improve mobile user experience and fix minor visual errors #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By making the grid layout responsive users on mobile devices no longer have to scroll horizontally to see all cookies. If there is not enough space in the header to fit the title and the name of the logged in user we now wrap the name of the logged in user into the next line.
|
Thank you! I will check this out this week and merge this PR if everything is okay :–) |
bespoyasov
approved these changes
Oct 6, 2021
|
Looks good! Thanks :–) |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the user experience for mobile users. The grid layout is now responsive. That means mobile users no longer have to scroll horizontally to see all cookies. Futhermore the name of the logged in user now breaks into the next line if there is not enough space to fit the title and the name in the header.
Apart from that I fixed some minor visual errors. By adding some padding to the cookie image the cookie no longer overlaps the text for the toppings. I added some spacing on the "In your cart"-text so it no longer sticks to the "add to cart"-button.