Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redefinition of macros and records #16

Open
aherranz opened this issue Nov 16, 2016 · 0 comments
Open

Redefinition of macros and records #16

aherranz opened this issue Nov 16, 2016 · 0 comments

Comments

@aherranz
Copy link

aherranz commented Nov 16, 2016

In order to compose several service requests I need to include some *.hrl files generated with soap:wsdl2erlang/1. The problem is that including them in the same module leads to compile errors because of the redefinition of the macro INTERFACE and the records faultdetail, faultcode, faultreasong, soap_fault_1_1, soap_fault_1_2 and qname.

I think it is not very difficult to avoid the problem:

  • I see the records are available from soap_fault.hrl and soap_wsdl_*.hrl.
  • Generated macro INTERFACE could include the name of the service in its name: INTERFACE_My_Service.
  • Generators should take into account that macro INTERFACE changes its name to the proper one.

The only limit, I think, is that qname record is defined in soap_wsdl_1_1.hrl and soap_wsdl_2_0.hrl and the client code should decide on which one to include.

What do you think?

PS. What a nice tool and library! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant