Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralized Defaults #104

Open
bh2smith opened this issue Nov 28, 2024 · 0 comments
Open

Centralized Defaults #104

bh2smith opened this issue Nov 28, 2024 · 0 comments

Comments

@bh2smith
Copy link
Owner

bh2smith commented Nov 28, 2024

Currently we have default configurations being set in many places:

  • at parsing time dict.get(value, default)
  • on the function parameters def func(x: bool = True)
  • dataclass attribute declarations field: type = x

We should decide on a single appropriate place to do this and stick with it.

My thoughts are the defaults to be applied at config parsing time and all the functions, field declarations require them to be set. The downside to this might be having to be very explicit in unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant