Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Dune Destination Save Doesn't Fail on Raised Error #136

Open
bh2smith opened this issue Jan 18, 2025 · 0 comments
Open

[Bug] Dune Destination Save Doesn't Fail on Raised Error #136

bh2smith opened this issue Jan 18, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@bh2smith
Copy link
Owner

While working the test adjustments to #129 - I noticed that we are only catching and logging errors. Not actually failing. Furthermore, we return the number of data points as if that were the number of affected rows. This can lead to incomplete jobs passing silently.

Some ideas:

  • Allow the errors to be raised
  • return boolean from job.run based on success or raised error
  • collect failures at the end
  • Report on failed jobs.

I am currently working on this task directly involving DuneDestination.save. Not sure if this should be fixed independently or just repaired in the overhaul.

@bh2smith bh2smith added the bug Something isn't working label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant