Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect calls to EventSpecialPoint #129

Closed
danielwe opened this issue Nov 14, 2023 · 2 comments
Closed

Incorrect calls to EventSpecialPoint #129

danielwe opened this issue Nov 14, 2023 · 2 comments

Comments

@danielwe
Copy link
Contributor

I believe the following calls to EventSpecialPoint are incorrect. Their signature does not match the method definition (line 243 in the same file, see below---as far as I can tell, there's only one method definition for this function). Specifically, the calls have 6 args instead of 5, and the types don't line up.

I found this while creating #128. I don't have enough context or understanding to know what the calls should have looked like, or how to write test cases that would have caught these errors.

userpoint = EventSpecialPoint(state, :user, status, recordFromSolution(iter), iter.normC, interval)

return false, EventSpecialPoint(state, Symbol(typeE), status, recordFromSolution(iter), iter.normC, interval)

return false, EventSpecialPoint(state, Symbol(typeE), status, recordFromSolution(iter), iter.normC, interval)

return false, EventSpecialPoint(state, :PairOfEvents, status, recordFromSolution(iter), iter.normC, interval)

return false, EventSpecialPoint(state, :SetOfEvents, status, recordFromSolution(iter), iter.normC, interval)

Here's the only method definition:

EventSpecialPoint(it::ContIterable, state::ContState, Utype::Symbol, status::Symbol, interval) = SpecialPoint(it, state, Utype, status, interval; idx = state.step + 1)

@rveltz
Copy link
Member

rveltz commented Nov 14, 2023

indeed! Thank you

@rveltz
Copy link
Member

rveltz commented Nov 18, 2023

closed with 096772d

@rveltz rveltz closed this as completed Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants