Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove select caches #20

Open
wasade opened this issue Jul 27, 2016 · 2 comments
Open

remove select caches #20

wasade opened this issue Jul 27, 2016 · 2 comments

Comments

@wasade
Copy link
Member

wasade commented Jul 27, 2016

This is dependent on being able to properly traverse the binary tree to identify the correct segment for a given value of k.

@wasade
Copy link
Member Author

wasade commented Aug 23, 2016

Have what appears to be an implementation as of b52eacc however, its performance on .collapse suggests it is not worth keeping (probably from preorderselect). Likely better ways to navigate the binary tree? The weirdest thing, during testing, saw essentially zero performance change when typing the code. As a result, my guess is getting hosed either by log2 or by pow which the binary tree ops rely on a lot especially for select. pow can be resolved by looking tables as we're only doing integers, and really shouldn't be getting too large. Could probably also do a lookup for log2 as we should only ever be calculating over a small range, and it is integer as well.

On the plus side, observed about a 20% reduction in runtime when parsing, and about a 20% reduction in space, when testing in EMP OR. But net loss due performance of critical ops.

@wasade
Copy link
Member Author

wasade commented Jan 27, 2022

It would be nice to remove the caches. It should be possible to calculate rank, select and excess from the rmm structure. However, this probably will be tedious to get correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant