From deed399882ba40257decbc44d1aee8ab5b5d0e2c Mon Sep 17 00:00:00 2001 From: David Steinacher Date: Mon, 13 Nov 2023 15:18:44 +0100 Subject: [PATCH 1/3] add missing nil check for playbackPositionHandler --- src/ts/components/seekbar.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ts/components/seekbar.ts b/src/ts/components/seekbar.ts index e6494691f..cf62ef002 100644 --- a/src/ts/components/seekbar.ts +++ b/src/ts/components/seekbar.ts @@ -254,7 +254,7 @@ export class SeekBar extends Component { // At the same time when the user is scrubbing, we also move the position of the seekbar to display a preview during scrubbing. // When the user is scrubbing we do not record this as a user seek operation, as the user has yet to finish their seek, // but we should not move the playback position to not create a jumping behaviour. - if (scrubbing && event.type === player.exports.PlayerEvent.SegmentRequestFinished && playbackPositionPercentage !== this.playbackPositionPercentage) { + if (scrubbing && event && event.type === player.exports.PlayerEvent.SegmentRequestFinished && playbackPositionPercentage !== this.playbackPositionPercentage) { playbackPositionPercentage = this.playbackPositionPercentage; } From bbfb934938241eac0110ecec0d82715e70e42360 Mon Sep 17 00:00:00 2001 From: David Steinacher Date: Mon, 13 Nov 2023 15:20:14 +0100 Subject: [PATCH 2/3] add changelog entry --- CHANGELOG.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index cb9f78012..e236e7fa7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/). +## [Unreleased] + +### Fixed +- Crash when receiving a `SourceLoaded` event during scrubbing + ## [3.52.0] - 2023-09-25 ### Fixed From 556ff7a724fd257f0fbba81250d6962eefe692c2 Mon Sep 17 00:00:00 2001 From: David Steinacher Date: Mon, 13 Nov 2023 16:05:03 +0100 Subject: [PATCH 3/3] update changelog header Co-authored-by: Giuseppe Samela --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e236e7fa7..cbfd16c34 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,7 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/). -## [Unreleased] +## [development] ### Fixed - Crash when receiving a `SourceLoaded` event during scrubbing