Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong title bar color on Firefox 133 #1030

Open
2 of 9 tasks
Dwedit opened this issue Nov 26, 2024 · 10 comments
Open
2 of 9 tasks

Wrong title bar color on Firefox 133 #1030

Dwedit opened this issue Nov 26, 2024 · 10 comments
Labels
Browser::Upstream Changes or bugs from Firefox Class::Color Color, background, blur, etc. Component::Tabbar Tab or tabbar Issue::Bug Something isn't working

Comments

@Dwedit
Copy link

Dwedit commented Nov 26, 2024

Describe the bug

Title Bar is the wrong color on Firefox 133, now forced at gray (and impossible to distinguish an active window from an inactive window)

Expected behavior

No response

Screenshots

No response

OS

Windows 10

OS - Others

No response

Firefox Version

133.0

Distribution

Theme

Theme - More Info

No response

user.js setup

_

Additional context

No response

@Dwedit Dwedit added the Issue::Bug Something isn't working label Nov 26, 2024
@TriggerHappyBro
Copy link

I use photon style and have the same issue, also on Win10 and I made sure I was using v8.6.4.

@fredgolightly
Copy link

Is this what you're seeing now, a grey bar/space between the tabs and the rest of the ui below? Similar issue on EdgeFox too

@Phlogistol
Copy link

Replacing all instances of '.titlebar-color' with '.browser-titlebar' in leptonChrome.css restores the color, but I'm not proficient enough with Firefox CSS to figure out how to keep the tab bottom grey.
screenshot

@fredgolightly
Copy link

Replacing all instances of '.titlebar-color' with '.browser-titlebar' in leptonChrome.css restores the color, but I'm not proficient enough with Firefox CSS to figure out how to keep the tab bottom grey.
It's like extra padding on the new 133 ff as this affects other themes I've just tried

@black7375 black7375 added Class::Color Color, background, blur, etc. Component::Tabbar Tab or tabbar Browser::Upstream Changes or bugs from Firefox labels Nov 27, 2024
@Phlogistol
Copy link

Phlogistol commented Nov 28, 2024

Okay, after some experimenting, I added these to userChrome.css:

.browser-titlebar {color: AccentColorText; background-color: AccentColor;}
#main-window:-moz-window-inactive .browser-titlebar {color: #5a5a5a; background-color:#F1F1F1;}
:root { --tabstrip-min-height: 26px !important; }

This is on Windows and it somewhat works. Hope it can be used to fix the main code.
Active window:
screen
Inactive window:
screen2

@Tech-How
Copy link

I just updated to the latest release and using the system color scheme on Windows, I still have a grey title bar where it should be following my system scheme. Is a fix for this in the works?

@hiyokosan
Copy link

Replacing all [.titlebar-color] with [.browser-titlebar] solves this problem.

@Mike500
Copy link

Mike500 commented Jan 7, 2025

Replacing all [.titlebar-color] with [.browser-titlebar] solves this problem.

That worked until today, with the new Firefox 134.0, sadly. It's all grey again, window active or not.

@Phlogistol
Copy link

It works if you add !important to the CSS elements. The following works for me on Firefox 134 on Windows 11 24H2.

.browser-titlebar { color: AccentColorText !important; background-color: AccentColor !important; }
#main-window:-moz-window-inactive .browser-titlebar { color: #5a5a5a !important; background-color:#F1F1F1 !important; }
:root { --tabstrip-min-height: 26px !important; }

@verbosemute
Copy link

Can confirm adding !important to the CSS elements. Works fine on Firefox 134 on Windows 10 22H2.

.browser-titlebar { color: AccentColorText !important; background-color: AccentColor !important; }

Hou-Rui pushed a commit to Hou-Rui/lepton-oneline that referenced this issue Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser::Upstream Changes or bugs from Firefox Class::Color Color, background, blur, etc. Component::Tabbar Tab or tabbar Issue::Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

9 participants