Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspector SAFETY message #1998

Open
Tracked by #769
Wodann opened this issue Jan 14, 2025 · 1 comment
Open
Tracked by #769

Inspector SAFETY message #1998

Wodann opened this issue Jan 14, 2025 · 1 comment

Comments

@Wodann
Copy link
Contributor

Wodann commented Jan 14, 2025

In the inspector code there is the following safety message:

// SAFETY: As the PC was already incremented we need to subtract 1 to preserve
// the old Inspector behavior.

Since we are making breaking changes, can that be removed? Or is there still a concern?

@rakita
Copy link
Member

rakita commented Jan 14, 2025

I would leave it decremented, as it is more obvious for PC to point to the current opcode and not the next one (or it could even point to the immediate byte).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants