Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up the public API #19

Open
bnjbvr opened this issue Nov 25, 2022 · 0 comments
Open

Clean up the public API #19

bnjbvr opened this issue Nov 25, 2022 · 0 comments

Comments

@bnjbvr
Copy link
Owner

bnjbvr commented Nov 25, 2022

It would be nice to generally clean up the public API:

  • BotConfig could use a builder pattern to construct itself, with a few defaults.
  • the run function might be split up, with the AppCtx being refactored into a TrinityBot that just contains what's needed to make the core things work. Then it's the responsibility of the library user to create a TrinityBot, and run it.
  • Splitting the lib and binary into two different crates would also help trim down dependency usage in the lib.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bnjbvr