Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GroupRepository 관련 Todo #18

Open
4 of 8 tasks
soopeach opened this issue Nov 20, 2022 · 0 comments
Open
4 of 8 tasks

GroupRepository 관련 Todo #18

soopeach opened this issue Nov 20, 2022 · 0 comments
Assignees
@soopeach
Labels
Todo 해야할 일! 현수

Comments

@soopeach
Copy link
Member

soopeach commented Nov 20, 2022 •
edited
Loading

🫣 관련 PR

😲 개요

  • data에서 사용하는 리터럴 제거
  • domain에 Enum class로 Exception 묶어두기
  • Exception 처리방법 공부하기
  • UserResponse.kt 에 있는 "-" 상수로 변경하기
  • UserResponse.kt 에 있는 String.toRule() 옮기기
  • toRule() 및 Rule.toString() 사용할 때 규칙이 없는 경우 처리
  • RepositoryImpl 들 @BINDS로 주입하기
  • GroupRepositoryImpl의 exitGroup 메서드 수정
    • return groupDataSource.joinGroup(uid, groupId) -> groupDataSource.exitGroup(uid, groupId)
@soopeach soopeach added the Todo 해야할 일! label Nov 20, 2022
@soopeach soopeach self-assigned this Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soopeach soopeach

Labels
Todo 해야할 일! 현수
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@soopeach