Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netlify setup #16

Open
p16i opened this issue Apr 1, 2020 · 2 comments
Open

Netlify setup #16

p16i opened this issue Apr 1, 2020 · 2 comments

Comments

@p16i
Copy link

p16i commented Apr 1, 2020

Hi,

Because this is a static web project, I think we can leverage Netlify's continuous deployment, which can fasten development process.

More precisely, if we have the Netlify integration in place, it can automatically build a new PR and host it on a certain domain that we can directly test before merging the code.

@r03ert0
Copy link
Member

r03ert0 commented Apr 1, 2020

Hola @heytitle !
At the moment brainweb is sooo static, that it doesn't require any building. And because we are directly using a GitHub page, we don't need deployment.
That said, it'd be good to write some tests. The code base is not too big at the moment, but that should change. In that case, continuous integration would be really helpful. We have no experience with Netlify, we mostly use CircleCI. Now, github also has its own continuous integration stuff, which could be interesting to try :D
Do you have experience writing tests for this kind of software? (it's mostly calls to different APIs...)

@p16i
Copy link
Author

p16i commented Apr 1, 2020

Hi @r03ert0 ,

Thanks for the reply. Actually, Netlify is more like for viewing changes live.

For example, if I create a PR fixing the hight of the top menu, Netlify will take my code and host it somewhere. So, you can see how the website looks like with my change.

Having said that. it's complement to CircleCI, which I guess it is normally used for regression tests.

Another GitHub Actions that might be helpful for this project:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants