Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow choosing the style from a dropdown #2

Open
Sebobo opened this issue Jun 25, 2019 · 11 comments · May be fixed by #9
Open

Allow choosing the style from a dropdown #2

Sebobo opened this issue Jun 25, 2019 · 11 comments · May be fixed by #9

Comments

@Sebobo
Copy link

Sebobo commented Jun 25, 2019

The are use cases where you should be able to select from a list of styles for the same piece of text.
The current mechanism would generate a button for each style and they might stack, when an editor presses several buttons.

With a dropdown it could be enforced that one of a set of styles is only selected. This would also use less space in cases where more than 3 styles are available.

I just started working on a time critical custom implementation and would try to create a PR for this package when I'm done.

@Sebobo
Copy link
Author

Sebobo commented Jun 26, 2019

We actually don't need so much. My first implementation mostly works and I was able to use the SelectBox from Neos and the Highlight plugin from CK5 https://ckeditor.com/docs/ckeditor5/latest/features/highlight.html#demo

I would prefer to use the Neos StyleSelect component, but it might need to be extended to give all the options.

@breadlesscode it could make sense to use the Highlight Plugin also for the normal buttons at some point. But it's not urgent.

@breadlesscode
Copy link
Owner

Thanks Seb for your support :)

Yes I think the StyleSelect should be fine. But atm I have no time to dive deeper in this component. I'm really curious to see what you implement 👍

@Sebobo
Copy link
Author

Sebobo commented Jun 28, 2019

I'm actually finished with the clients implementation, just having a problem with CK and Neos itself. When you include plugins that have dependencies on the CK core, you get errors and warnings in the backend. Everything still seems to work, but I wouldn't put it into production this way.
Will have a discussion with other UI people next week on how to solve this.

@breadlesscode
Copy link
Owner

@Sebobo Any progress here? If not I will have a look at this issue :)

That would be an awesome feature.

@Sebobo
Copy link
Author

Sebobo commented Sep 2, 2019

Just came back from holiday and was focused on the RedirectHandler. Can start on this topic next week :)
Maybe I'll just start a draft PR with some code and we can work on it together.

@Sebobo Sebobo linked a pull request Sep 25, 2019 that will close this issue
@Sebobo
Copy link
Author

Sebobo commented Sep 25, 2019

@breadlesscode finally took some time ;) You can already check out my draft PR #9 if you like.

@breadlesscode
Copy link
Owner

Thank you :)

I will check that tomorrow

@Sebobo
Copy link
Author

Sebobo commented Sep 27, 2019

Open todos:

  • (Optionally) Make it possible to select style options instead of just css classes
  • Enable previous button plugin again (disabled because of some CK duplicate import error)
  • More testing

@breadlesscode
Copy link
Owner

Sorry to keep you waiting. I did not forget you :)

This week I will have a look at your PR and hopefully fix the open Todos 👍

@Sebobo
Copy link
Author

Sebobo commented Sep 30, 2019

Oh I can also do that, but was sick last week. But feel free to change stuff if you are faster than me ;)

@Benjamin-K
Copy link

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants