Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Pipeline #269

Closed
tsengia opened this issue Sep 28, 2023 · 10 comments
Closed

CI Pipeline #269

tsengia opened this issue Sep 28, 2023 · 10 comments

Comments

@tsengia
Copy link
Contributor

tsengia commented Sep 28, 2023

Describe the feature you'd like
Hello,
I am making this issue to propose creating a CI pipeline for compiling the application and for checking that merge requests compile correctly.

Describe alternatives you've considered
None considered, manually compiling on own device for each merge request + change is current way of doing things.

Additional context
I am mostly making this issue because I plan on attempting to implement this feature myself.
If I am able to get a CI build process working then I will create a merge request to add it in :)

@tsengia
Copy link
Contributor Author

tsengia commented May 13, 2024

@brodeurlv This is probably a newbie question, but which JDK version are you using? 11 or 17?

I've gotten the CI pipeline to build successfully but I had to bump the JDK version to 17 in order for it to work otherwise gradle complained saying that I needed 17.

@tsengia
Copy link
Contributor Author

tsengia commented Jan 6, 2025

I've started taking a look at this again and I've been getting build issues due to the time picker with seconds library not being present on JCentral anymore (IvanKovac/TimePickerWithSeconds#11)

Possible options are:

  • Re-upload the library on Maven Central and update dependencies files
  • Include the two .java files that the library provides (ie. vendor them)

@brodeurlv
Copy link
Owner

brodeurlv commented Jan 6, 2025 via email

@brodeurlv
Copy link
Owner

brodeurlv commented Jan 6, 2025 via email

@tsengia
Copy link
Contributor Author

tsengia commented Jan 7, 2025

This will fix the issues you saw.

I'm not sure if you've pushed anything...? Did you make new commits on master or did you push up a new artifact somewhere?
Thank you for your help, as you can tell I'm not an expert at Android development and still learning.

@brodeurlv
Copy link
Owner

brodeurlv commented Jan 7, 2025 via email

@brodeurlv
Copy link
Owner

brodeurlv commented Jan 8, 2025

Hi @tsengia ,
I have committed my code but I have to resolve some merge conflicts.

@brodeurlv
Copy link
Owner

Should be ok now.

@tsengia
Copy link
Contributor Author

tsengia commented Jan 11, 2025

It works! Thank you.

@tsengia
Copy link
Contributor Author

tsengia commented Jan 18, 2025

Closing this after PR was merged

@tsengia tsengia closed this as completed Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants