-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Pipeline #269
Comments
@brodeurlv This is probably a newbie question, but which JDK version are you using? 11 or 17? I've gotten the CI pipeline to build successfully but I had to bump the JDK version to 17 in order for it to work otherwise gradle complained saying that I needed 17. |
I've started taking a look at this again and I've been getting build issues due to the time picker with seconds library not being present on JCentral anymore (IvanKovac/TimePickerWithSeconds#11) Possible options are:
|
Hi Tyler, I'll push an update soon to comply with the latest api. I'll do
it today or tomorrow.
Le lun. 6 janv. 2025, 02:31, Tyler Sengia ***@***.***> a
écrit :
… I've started taking a look at this again and I've been getting build
issues due to the time picker with seconds library not being present on
JCentral anymore (IvanKovac/TimePickerWithSeconds#11
<IvanKovac/TimePickerWithSeconds#11>)
Possible options are:
- Re-upload the library on Maven Central and update dependencies files
- Include the two .java files that the library provides (ie. vendor
them)
—
Reply to this email directly, view it on GitHub
<#269 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD65NDQOE6T2P6WFNIKO6SL2JHMITAVCNFSM6AAAAABUUVT32CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZRHA3TONJWGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This will fix the issues you saw.
Le lun. 6 janv. 2025, 07:58, Brodeur Levrai ***@***.***> a
écrit :
… Hi Tyler, I'll push an update soon to comply with the latest api. I'll do
it today or tomorrow.
Le lun. 6 janv. 2025, 02:31, Tyler Sengia ***@***.***> a
écrit :
> I've started taking a look at this again and I've been getting build
> issues due to the time picker with seconds library not being present on
> JCentral anymore (IvanKovac/TimePickerWithSeconds#11
> <IvanKovac/TimePickerWithSeconds#11>)
>
> Possible options are:
>
> - Re-upload the library on Maven Central and update dependencies files
> - Include the two .java files that the library provides (ie. vendor
> them)
>
> —
> Reply to this email directly, view it on GitHub
> <#269 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AD65NDQOE6T2P6WFNIKO6SL2JHMITAVCNFSM6AAAAABUUVT32CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZRHA3TONJWGU>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
I'm not sure if you've pushed anything...? Did you make new commits on master or did you push up a new artifact somewhere? |
Hi Tyler, no I did not have time yesterday finally but it will come in the
coming days. Tonight I hope.
Le mar. 7 janv. 2025, 04:31, Tyler Sengia ***@***.***> a
écrit :
… This will fix the issues you saw.
I'm not sure if you've pushed anything...? Did you make new commits on
master or did you push up a new artifact somewhere?
Thank you for your help, as you can tell I'm not an expert at Android
development and still learning.
—
Reply to this email directly, view it on GitHub
<#269 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD65NDXA2D7ITQZRS5Y2MMT2JNDB5AVCNFSM6AAAAABUUVT32CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZUGMZDIOBZHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi @tsengia , |
Should be ok now. |
It works! Thank you. |
Closing this after PR was merged |
Describe the feature you'd like
Hello,
I am making this issue to propose creating a CI pipeline for compiling the application and for checking that merge requests compile correctly.
Describe alternatives you've considered
None considered, manually compiling on own device for each merge request + change is current way of doing things.
Additional context
I am mostly making this issue because I plan on attempting to implement this feature myself.
If I am able to get a CI build process working then I will create a merge request to add it in :)
The text was updated successfully, but these errors were encountered: