Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double clicking on the overlay very quickly(less than 250ms by default) will leave the lightbox shown and not able to be closed. #51

Open
seanyao opened this issue Feb 28, 2013 · 0 comments

Comments

@seanyao
Copy link

seanyao commented Feb 28, 2013

The Issue #17 is not fixed. It's better to fix this by moving the events binding logic into a single method and called after the animation completed.

You can reproduce this easily by extending the default overlaySpeed larger than 1000ms.

Code sample:

            Line #74:  $self[opts.appearEffect](opts.lightboxSpeed, function() { setOverlayHeight(); setSelfPosition(); opts.onLoad(); bindEvents()});
            function bindEvents(){
                $(window).resize(setOverlayHeight)
                     .resize(setSelfPosition)
                     .scroll(setSelfPosition);

            $(window).bind('keyup.lightbox_me', observeKeyPress);

            if (opts.closeClick) {
                $overlay.click(function(e) { closeLightbox(); e.preventDefault; });
            }
            $self.delegate(opts.closeSelector, "click", function(e) {
                closeLightbox(); e.preventDefault();
            });
            $self.bind('close', closeLightbox);
            $self.bind('reposition', setSelfPosition);
        }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant