Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

204 Response Returned on a Deleted (Tombstoned) Item #114

Open
scholary-tim opened this issue Jun 11, 2013 · 3 comments
Open

204 Response Returned on a Deleted (Tombstoned) Item #114

scholary-tim opened this issue Jun 11, 2013 · 3 comments
Labels
Milestone

Comments

@scholary-tim
Copy link

When an item is tombstoned, it does not appear to be deleted from the system, but instead, alterered to contain deleted-item xml data (as seen in the atompub-tombstones draft).

Replication Steps:
Send a DELETE request to an existing post/reply item on a personal channel. Confirm 'deleted' from channel. A 204 (No Content) should be returned.
Send the same request in again.

Expected Outcome:
404 (Not Found) returned.

Actual Outcome:
204 (No Content) returned.

@scholary-tim
Copy link
Author

Following conversation with @lloydwatkin - it may be preferable (enhancement), if we keep the 204 response here, to introduce the functionality for a channel owner (or moderator) to be able to retrieve tombstoned items (e.g. give me all items, inclusive of those marked as deleted items).

@imaginator
Copy link
Member

204 also looks correct when examining the spec:

204 No Content

The server has fulfilled the request but does not need to return an entity-body, and might want to return updated metainformation. The response MAY include new or updated metainformation in the form of entity-headers, which if present SHOULD be associated with the requested variant.

@scholary-tim
Copy link
Author

I guess my thoughts are how do you differentiate between "I've just deleted this item", and "This item is already deleted" or "This item does not exist."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants