Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restoring image edit for current blog, preserving global media tab editing lock #133

Open
darkfire56j opened this issue Nov 8, 2021 · 1 comment
Labels

Comments

@darkfire56j
Copy link

darkfire56j commented Nov 8, 2021

I was struggling with a bug. All is fine with your plugin except one thing:

Enabling this plugin in my wordpress version (latest at today) suddenly introduce a bug: clicking in "edit image" for local blog images (I mean the regular Browse tab, not yours) does not work.

I fixed this changing your global-media.js file and reintroducing this to Select extend:

this.on('content:render:edit-image', this.editImageContent, this);
and then:

editImageContent: function() {
    var image = this.state().get('image'),
        view = new wp.media.view.EditImage( { model: image, controller: this } ).render();

    this.content.set( view );

    // After creating the wrapper view, load the actual editor via an Ajax call.
    view.loadEditor();
},

I share this bugfix with you because I really appreciate your work <3

@bueltge
Copy link
Owner

bueltge commented Nov 9, 2023

Thanks @darkfire56j Would you create a fix for that, creating of a Pull Request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants