Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display upload/download progress bar on the CLI #283

Open
calvinrp opened this issue May 13, 2024 · 4 comments
Open

Display upload/download progress bar on the CLI #283

calvinrp opened this issue May 13, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@calvinrp
Copy link
Collaborator

When uploading/downloading files, display a nice progress bar indicator that shows the progress.

@calvinrp calvinrp added the enhancement New feature or request label May 13, 2024
@MarinPostma
Copy link
Contributor

I'm working on that

@MarinPostma
Copy link
Contributor

loosely related to that, but while implementing the progress bar for downloads I found that: https://github.com/bytecodealliance/registry/blob/main/src/commands/dependencies.rs#L50-L52

Is it intentional that download is called twice with the exact same args?

@calvinrp
Copy link
Collaborator Author

calvinrp commented Sep 24, 2024

loosely related to that, but while implementing the progress bar for downloads I found that: https://github.com/bytecodealliance/registry/blob/main/src/commands/dependencies.rs#L50-L52

Is it intentional that download is called twice with the exact same args?

That looks like a mistake. This code and command for dependency resolution isn't fully being used yet.

The warg client is likely going to be replaced by the https://crates.io/crates/wkg client for most users. Not yet, but very soon. It supports both Warg and OCI registries.

@MarinPostma
Copy link
Contributor

I removed the duplicate in my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants