Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add confirmation dialog describing consequences of warg yank #289

Closed
lann opened this issue May 15, 2024 · 1 comment
Closed

Add confirmation dialog describing consequences of warg yank #289

lann opened this issue May 15, 2024 · 1 comment

Comments

@lann
Copy link
Collaborator

lann commented May 15, 2024

As discussed in #264, the behavior of "yank" may not be obvious to someone unfamiliar with cargo yank. Regardless of the name of the operation, we should probably have a confirmation dialog there, describing that it will irreversibly make the release (effectively) unusable.
@lann lann mentioned this issue May 15, 2024
Open
@calvinrp calvinrp mentioned this issue May 15, 2024
Merged
calvinrp added a commit that referenced this issue May 15, 2024
@calvinrp
Client publish improvement and yank confirmation (#290)
14b98ac 
- added a client method `sign_with_keyring_and_publish` ("keyring"
feature required), making it easier for other crates that use the
`warg-client` enable publishing
- when `warg publish yank`, adds a confirmation and more description
#289 #264
@calvinrp
Copy link
Collaborator

Fixed in #290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lann @calvinrp