Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support no_std (again) #6424

Closed
stevefan1999-personal opened this issue May 22, 2023 · 4 comments
Closed

Support no_std (again) #6424

stevefan1999-personal opened this issue May 22, 2023 · 4 comments

Comments

@stevefan1999-personal
Copy link

Thanks for filing a feature request! Please fill out the TODOs below.

Feature

Add no_std back to the equation.

Benefit

So we can build a safer eBPF implementation in Linux kernel

Implementation

We could use https://gitlab.com/jD91mZM2/no-std-compat for this.

Alternatives

Don't attempt to rewrite eBPF

@jameysharp
Copy link
Contributor

I assume you want no_std in Cranelift specifically, and you don't care about Wasmtime, right?

The most recent time this came up was #6131 and the discussion there is still relevant. Unfortunately the person who authored that PR apparently gave up and deleted their branch after we asked for the additional work we'd need to make sure we can reliably maintain no_std support for Cranelift going forward.

There's some work to do but I think it's a fairly straightforward path if you want to work on it. I'd be happy to answer questions!

@stevefan1999-personal
Copy link
Author

I assume you want no_std in Cranelift specifically, and you don't care about Wasmtime, right?

Correct. I should be more specific.

The most recent time this came up was #6131 and the discussion there is still relevant. Unfortunately the person who authored that PR apparently gave up and deleted their branch after we asked for the additional work we'd need to make sure we can reliably maintain no_std support for Cranelift going forward.

Well, he/she just deleted all their GH repos. But if we still have the patch set we can just try and apply the hunks manually. But this would mean their cobtribution commit would be lost. Not sure if I can just cherrypick the the PR branch...

There's some work to do but I think it's a fairly straightforward path if you want to work on it. I'd be happy to answer questions!

@alexcrichton
Copy link
Member

If still interested, I've opened a plan for this at #8341

@alexcrichton
Copy link
Member

Wasmtime now supports no_std, and I'll defer supporting no_std in Cranelift to #1158, so closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants