Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update examples for startedAt values in qod-provisioning.yaml #389

Open
gmuratk opened this issue Jan 7, 2025 · 2 comments
Open

Update examples for startedAt values in qod-provisioning.yaml #389

gmuratk opened this issue Jan 7, 2025 · 2 comments
Labels
correction correction in documentation or alignment with commonalities Spring25 Issue in scope of Spring25 meta-release cycle

Comments

@gmuratk
Copy link

gmuratk commented Jan 7, 2025

Problem description

It is reported that some tool chains are having issues with string values without quotes for properties defined in datetime format. In qod-provisioning.yaml such instances exist for startedAt in the examples section.

examples:
PROVISIONING_AVAILABLE:
summary: QoD provisioning status is available
description: The provisioning has become available
value:
device:
phoneNumber: "+123456789"
qosProfile: QOS_L
sink: https://application-server.com/callback
sinkCredential:
credentialType: ACCESSTOKEN
accessToken: "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiaWF0IjoxNTE2MjM5MDIyfQ.SflKxwRJSMeKKF2QT4fwpMeJf36POk6yJV_adQssw5c"
accessTokenExpiresUtc: "2024-12-01T12:00:00Z"
accessTokenType: bearer
provisioningId: 3fa85f64-5717-4562-b3fc-2c963f66afa6
startedAt: 2024-05-12T17:32:01Z
status: AVAILABLE

Expected behavior

Wrap all instances of startedAt values in examples with quotes, same as the other properties with same format (e.g. accessTokenExpiresUtc)

Alternative solution

n/a
Additional context

n/a
@gmuratk gmuratk added the correction correction in documentation or alignment with commonalities label Jan 7, 2025
@jlurien
Copy link
Collaborator

jlurien commented Jan 10, 2025

I will fix this in the new PR to align the API with the latest Commonalities

@hdamker hdamker added the Spring25 Issue in scope of Spring25 meta-release cycle label Jan 10, 2025
@eric-murray eric-murray mentioned this issue Jan 10, 2025
Open
@eric-murray
Copy link
Collaborator

@gmuratk
I included the changes in PR #391. Can you review to ensure this fixes your issue? Thanks.

@hdamker hdamker mentioned this issue Jan 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
correction correction in documentation or alignment with commonalities Spring25 Issue in scope of Spring25 meta-release cycle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jlurien @hdamker @eric-murray @gmuratk