Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error responses and test cases to comply with Commonalities 0.5.0 #391

Open
wants to merge 60 commits into
base: main
Choose a base branch
from
Open

Update error responses and test cases to comply with Commonalities 0.5.0 #391

wants to merge 60 commits into from

Conversation

eric-murray
Copy link
Collaborator

@eric-murray eric-murray commented Jan 10, 2025 •
edited
Loading

What type of PR is this?

  • correction

What this PR does / why we need it:

Commonalities 0.5.0-alpha.1 updates the error response codes associated with device handling.

This PR:

  • Updates the error response codes and schemas as necessary in the OAS definitions
  • Updates the test cases as necessary
  • Removes the 403 INVALID_TOKEN_CONTEXT error from the OAS definitions
  • Removes all 5XX errors as these no longer require to be explicitly documented
  • Updates info.description text on device object handling in each OAS definition
  • Ensures date-time examples are enclosed by quotation marks

Which issue(s) this PR fixes:

Fixes #390, #392, #389, #394

Special notes for reviewers:

None

Changelog input

 release-note
 - Updates the error response codes and schemas as necessary in the OAS definitions
 - Updates the test cases as necessary
 - Removes the `403 INVALID_TOKEN_CONTEXT` error from the OAS definitions
 - Removes all 5XX errors as these no longer require to be explicitly documented
 - Updates `info.description` text on device object handling in each OAS definition
 - Ensures `date-time` examples are enclosed by quotation marks

Additional documentation

None

@eric-murray
Update quality-on-demand.yaml
6147be3
@eric-murray
Update qos-profiles.yaml
0890191
@eric-murray
Update qod-provisioning.yaml
b4d6908
@eric-murray
Update quality-on-demand.yaml
44fbcdd
@eric-murray
Update qos-profiles.yaml
4eb09eb
@eric-murray
Update qod-provisioning.yaml
67d317e
@eric-murray
Update qod-provisioning-createProvisioning.feature
9022747
@eric-murray
Update qod-provisioning-deleteProvisioning.feature
9568741
@eric-murray
Update qod-provisioning-getProvisioningById.feature
b201f09
@eric-murray
Update qod-provisioning-retrieveProvisioningByDevice.feature
9edbf0b
@eric-murray
Update qod-provisioning-createProvisioning.feature
fcee50e
@eric-murray
Update qod-provisioning-deleteProvisioning.feature
fc9e3f7
@eric-murray
Update qod-provisioning-getProvisioningById.feature
9839871
@eric-murray
Update qod-provisioning-retrieveProvisioningByDevice.feature
4a63f7a
@eric-murray
Update qos-profiles-getQosProfile.feature
cc80d92
@eric-murray
Update qos-profiles-retrieveQoSProfiles.feature
0871500
@eric-murray
Update qod-provisioning-retrieveProvisioningByDevice.feature
6a797e3
@eric-murray
Update quality-on-demand-createSession.feature
a2549ba
@eric-murray
Update qod-provisioning-createProvisioning.feature
14f4ef9
@eric-murray
Update qod-provisioning-deleteProvisioning.feature
2de4ea5
@eric-murray
Update qod-provisioning-getProvisioningById.feature
79ef0d0
@eric-murray
Update qod-provisioning-createProvisioning.feature
9da7ebb
@eric-murray
Update qod-provisioning-deleteProvisioning.feature
1606547
@eric-murray
Update qod-provisioning-retrieveProvisioningByDevice.feature
e56f610
@eric-murray
Update qos-profiles-getQosProfile.feature
2c302c6
@eric-murray
Update qos-profiles-retrieveQoSProfiles.feature
836f1b0
@eric-murray
Update quality-on-demand-deleteSession.feature
143b99c
@eric-murray
Update quality-on-demand-extendQosSessionDuration.feature
0f17774
@eric-murray
Update quality-on-demand-getSession.feature
fce4fe2
@eric-murray
Update quality-on-demand-retrieveSessionsByDevice.feature
88e6691
@hdamker hdamker mentioned this pull request Jan 11, 2025
Open
hdamker
hdamker reviewed Jan 14, 2025
View reviewed changes
code/Test_definitions/quality-on-demand-createSession.feature
@@ -275,19 +275,6 @@ Feature: CAMARA Quality On Demand API, v0.11.1 - Operation createSession

# Errors 403
Copy link
Collaborator

@hdamker hdamker Jan 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to keep the line if there is no test case in this section?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added 403 "missing scope" errors for all feature files

hdamker
hdamker previously approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ... for all the changes I have checked. Thanks @eric-murray for the effort!

@eric-murray
Update quality-on-demand-createSession.feature
d4aafd9
@eric-murray
Update qod-provisioning-createProvisioning.feature
6fc3275
@eric-murray
Update qod-provisioning-createProvisioning.feature
08370f0
@eric-murray
Update quality-on-demand-createSession.feature
edd2c51
@eric-murray
Update qod-provisioning-createProvisioning.feature
b76fb95
@eric-murray
Update qod-provisioning-deleteProvisioning.feature
a281bf8
@eric-murray
Update qod-provisioning-getProvisioningById.feature
3c2066b
@eric-murray
Update qod-provisioning-retrieveProvisioningByDevice.feature
14a90ad
@eric-murray
Update qos-profiles-getQosProfile.feature
9c8997b
@eric-murray
Update qos-profiles-retrieveQoSProfiles.feature
28edd70
@eric-murray
Update quality-on-demand-deleteSession.feature
da4d45d
@eric-murray
Update quality-on-demand-extendQosSessionDuration.feature
8757a40
@eric-murray
Update quality-on-demand-getSession.feature
0800211
@eric-murray
Update quality-on-demand-retrieveSessionsByDevice.feature
93c0f79
@eric-murray eric-murray mentioned this pull request Jan 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlurien jlurien jlurien left review comments

@gmuratk gmuratk gmuratk approved these changes

@hdamker hdamker hdamker left review comments

@RandyLevensalor RandyLevensalor Awaiting requested review from RandyLevensalor RandyLevensalor is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Spring25 Issue in scope of Spring25 meta-release cycle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update error codes in API definitions and test cases
4 participants
@eric-murray @jlurien @hdamker @gmuratk