Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor/Rust: more comprehensive dependency removal #72

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

liushuyu
Copy link

@liushuyu liushuyu commented Dec 2, 2024

This pull request simplifies the vendored dependency removal process using a new tool from dh-cargo (currently unreleased).

Additionally, I added one more command to remove the js-sys* stuff (some Rust libraries can be compiled into WebAssembly modules, which will pull in some JavaScript platform libraries for web browser interactions).

@liushuyu liushuyu marked this pull request as draft December 2, 2024 23:12
@setharnold
Copy link
Contributor

I'm curious about removing js-sys* -- what if that portion is the goal of the package? we do ship web things, eg ckeditor and probably more.

Thanks

@cpaelzer
Copy link
Collaborator

cpaelzer commented Dec 3, 2024

This is still Draft, so not reviewing in depth.
But in general while I like that this gets a proper tool, due to it being only available in future should we make it more "use A (old way) or if available the more modern B ( tool)"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants