Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: CDS button kinds 'danger-tertiary' and 'danger-ghost' are not working. #18085

Closed
2 tasks done
alexpeverett opened this issue Jul 4, 2024 · 1 comment · Fixed by #18117
Closed
2 tasks done
Assignees
Labels

Comments

@alexpeverett
Copy link

alexpeverett commented Jul 4, 2024

Package

carbon-components

Browser

Chrome

Package version

2.8.0/2.10.0

Description

Both 'danger-tertiary' and 'danger-ghost' button kinds are not working as intended. Not working in 2.10.0 (web-components.carbondesignsystem.com) and in 2.8.0 (project I'm working on).

Screenshots

Screenshot 2024-07-04 at 15 09 34 Screenshot 2024-07-04 at 15 09 45 Screenshot 2024-07-04 at 15 10 12 Screenshot 2024-07-04 at 15 10 45

Steps to reproduce

Create a CDS button and set it's kind to either 'danger-tertiary' or 'danger-ghost'.

Code of Conduct

@tay1orjones tay1orjones transferred this issue from carbon-design-system/carbon Jul 8, 2024
@AlessandroPomponio
Copy link

AlessandroPomponio commented Nov 15, 2024

By navigating to the default button Storybook page and using inspect element I can see that the classes being assigned to the danger-ghost button seem to be:

 cds--btn cds--btn--danger-ghost 

While if I navigate to the danger button Storybook page and do the same I see that the classes are:

cds--btn cds--btn--danger--ghost

It looks like the kind of the danger-ghost button has changed to be danger--ghost instead of danger-ghost as documented. (this can also be seen in the same way using inspect element)

EDIT: note that selecting danger--ghost as a kind instead of danger-ghost, however, makes the icon off-center

@tay1orjones tay1orjones transferred this issue from carbon-design-system/carbon-for-ibm-dotcom Nov 15, 2024
@tay1orjones tay1orjones added severity: 2 https://ibm.biz/carbon-severity component: button package: @carbon/web-components @carbon/web-components labels Nov 15, 2024
@annawen1 annawen1 self-assigned this Nov 19, 2024
@annawen1 annawen1 moved this from 🕵️‍♀️ Triage to 🏗 In Progress in Design System Nov 19, 2024
@preetibansalui preetibansalui moved this from 🏗 In Progress to 🚦 In Review in Design System Nov 20, 2024
@github-project-automation github-project-automation bot moved this from 🚦 In Review to ✅ Done in Design System Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants