Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make key quality of life updates to automated archiving #418

Closed
3 of 6 tasks
e-belfer opened this issue Sep 3, 2024 · 2 comments
Closed
3 of 6 tasks

Make key quality of life updates to automated archiving #418

e-belfer opened this issue Sep 3, 2024 · 2 comments
Assignees
Labels
automation Issues relating to automated archiver runs

Comments

@e-belfer
Copy link
Member

e-belfer commented Sep 3, 2024

The following challenges were observed in the September archive #412, and would speed the pace of monthly archiving:

Tasks

Preview Give feedback
  1. ferc1 ferc2 ferc6 ferc60 ferc714
    zschira
@zschira
Copy link
Member

zschira commented Oct 16, 2024

I've done some further research into the erroneous FERC XBRL archive updates and found the following:

  1. he hashes of the zipfiles do differ
  2. The contents of the zipfiles are, however, identical and there are no longer partition changes, meaning Fix erroneous FERC XBRL updates #433 did fix the partition change error and the changes to the rssfeed file
  3. The sizes of the zipfiles are identical
  4. The timestamps of the files within the zips are identical

I'm still not really sure how/why the zips are differing. I tried creating a test to create 2 archives and check the hashes, but I'm unable to reproduce the error.

I'm going to try modifying the XBRL archivers to use our existing add_to_archive_stable_hash method and create two new archive versions for comparison. It does feel like directly comparing hashes of zipfiles is probably a bit fragile and a more in depth comparison might be better, but if add_to_archive_stable_hash solves the problem then it's probably good enough for now.

@jdangerx
Copy link
Member

jdangerx commented Nov 4, 2024

Pulled out remaining pieces. closing

@jdangerx jdangerx closed this as completed Nov 4, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Catalyst Megaproject Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Issues relating to automated archiver runs
Projects
Archived in project
Development

No branches or pull requests

3 participants