When token not mandatory and none given, problems occur when there are courses with self-enrolment and empty tokens

[JorritDeKlerk]

I was just wondering if this is by design:

• Have some courses with self-enrolment but WITHOUT tokens.
• In the settings for enrolkey:
• Set 'Require enrolment key for validation' to No
• Set 'Require email confirmation' to Yes
• Create a new user but keep the field for the token empty
• Two "problems" now:
• User is enrolled in the first course that has an empty token with self-enrolment.
• For all other courses with empty token an error is shown (to the user)
• Because of these errors, the email confirmation is not send AND the user is also automatically logged in (!)

I think it is more logical to ignore empty tokens.

A very dirty quick hack to show how to 'fix' it:

auth.txt

[brendanheywood]

@JorritDeKlerk are you able to submit that as a github pull request rather than static patch file please? It will make it far easier for us to merge it as well as giving you the commit kudos

[SYoung3000]

To add to this, I think it happens if the course has group enrolment keys and any of these are left blank. The user doesn't seem to get added to the group, at least not immediately, but they do get enrolled in the course which seems unintuitive