From 260a806dca5b0ff1d89506a1da53b168822ea68f Mon Sep 17 00:00:00 2001 From: Heberto Mayorquin Date: Thu, 19 Dec 2024 08:30:23 -0600 Subject: [PATCH] fix test and add changelog --- CHANGELOG.md | 2 +- .../datainterfaces/ecephys/intan/intandatainterface.py | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7488d5834..a9ae7fe75 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,7 +14,7 @@ * `SpikeGLXConverterPipe` converter now accepts multi-probe structures with multi-trigger and does not assume a specific folder structure [#1150](https://github.com/catalystneuro/neuroconv/pull/1150) * `SpikeGLXNIDQInterface` is no longer written as an ElectricalSeries [#1152](https://github.com/catalystneuro/neuroconv/pull/1152) * Fix a bug on ecephys interfaces where extra electrode group and devices were written if the property of the "group_name" was set in the recording extractor [#1164](https://github.com/catalystneuro/neuroconv/pull/1164) - +* Fix metadata bug in `IntanRecordingInterface` where incorrected devices were added if the recording contained multiple electrode groups or names [#1166](https://github.com/catalystneuro/neuroconv/pull/1166) ## Features * Propagate the `unit_electrode_indices` argument from the spikeinterface tools to `BaseSortingExtractorInterface`. This allows users to map units to the electrode table when adding sorting data [PR #1124](https://github.com/catalystneuro/neuroconv/pull/1124) diff --git a/src/neuroconv/datainterfaces/ecephys/intan/intandatainterface.py b/src/neuroconv/datainterfaces/ecephys/intan/intandatainterface.py index 2d7c849f2..5e4ee4460 100644 --- a/src/neuroconv/datainterfaces/ecephys/intan/intandatainterface.py +++ b/src/neuroconv/datainterfaces/ecephys/intan/intandatainterface.py @@ -92,7 +92,8 @@ def get_metadata(self) -> dict: electrode_group_metadata = ecephys_metadata["ElectrodeGroup"] electrode_group_metadata[0]["device"] = intan_device["name"] - + # for electrode_group in electrode_group_metadata: + # electrode_group["device"] = intan_device["name"] # Add electrodes and electrode groups ecephys_metadata.update( ElectricalSeriesRaw=dict(name="ElectricalSeriesRaw", description="Raw acquisition traces."),