Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use case for ControllerLookup? #17

Open
twalcari opened this issue Dec 5, 2014 · 1 comment
Open

Use case for ControllerLookup? #17

twalcari opened this issue Dec 5, 2014 · 1 comment

Comments

@twalcari
Copy link
Contributor

twalcari commented Dec 5, 2014

Is ControllerLookup still a relevant feature?

As fx-guice is now targeting JavaFX8, and thus supports all features introduced in JavaFX2.2, it also supports getting access to child-controllers as follows:

<VBox fx:controller="com.foo.MainController"> 
...
    <fx:include fx:id="dialog" source="dialog.fxml"/>
...
</VBox>

public class MainController extends Controller { 
    @FXML private Window dialog;
    @FXML private DialogController dialogController;

    ...
}

(source: http://docs.oracle.com/javafx/2/fxml_get_started/whats_new2.htm)

For me, it seems best to remove this class, as - to be useful-, it relies on ParentID, which is broken in JavaFX8.

@headcr4sh
Copy link
Member

ControllerLookup is not a valid feature anymore for JavaFX 8. Are you willing to provide a patch that removes the feature for the upcoming release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants