Multi-servers support (primus-redis)

[gregberge]

I have worked on a fork of primus-redis to be compatible with your stack. I support almost all of your plugins, but not multiplex.

Syncing between servers is primordial for scaling.

May be you can take a look and help me to make a primus-redis fully compatible with your stack?

https://github.com/neoziro/primus-redis

Thanks.

[cayasso]

Sure I will be happy to help! the secret here is to treat a channel
instance in multiplex as a primus instance, so whatever change that you
made for primus (server) will/should also apply for it.
I will take a look at your code in a bit and see if we can figure this out
:)

Best!

On Monday, January 20, 2014, Greg Bergé [email protected] wrote:

I have worked on a fork of primus-redis to be compatible with your stack.
I support almost all of your plugins, but not multiplex.

Syncing between servers is primordial for scaling.

May be you can take a look and help me to make a primus-redis fully
compatible with your stack?

https://github.com/neoziro/primus-redis

Thanks.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/6
.

J.B.

[gregberge]

Ok thanks !

[cayasso]

Hey @neoziro apologizes I haven't forgot about this change, actually because of this issue I am doing a rewrite of primus-rooms and primus-multiplex to make it easy to be compatible with your redis plugin(methods from the adapter would be asynchronous), I am going to be moving 3 methods from primus-rooms rooms.js to adapter.js, clear, empty and isEmpty. I am trying to make all test to pass, I will push some code soon and also will push some PR to your project for you to review.

Best,
JB

[gregberge]

Ho it's a very great news ! If we can make primus-redis fully compatible with your stack it will be very nice for all. I actually use Primus (and all of your plugins except multiplex) on a CMS project for Le Monde (first newspaper in France) and it works very well.

I would to talk you about another issue : actually primus-resource asks "primus-multiplex" as a dependency, but in reality if we call resource with resource("myresource", false) it doesn't need this dependency to work. So can you remove this dependency and just emit the error when necessary ? Actually I use a "fake-multiplex" plugin to fill the Primus.$.multiplex variable, it's a hack...

[cayasso]

@neoziro cayasso/primus-resource@4a5765a primus-resource 2.0.2 is out with the change above.

[cayasso]

Glad to know these plugins are being useful to others :)

[gregberge]

@cayasso thanks, i will remove my fake-multiplex :)

[aslakhellesoy]

Guys - this sounds awesome. I'd love to use @neoziro's primus-redis with primus-rooms. Is there anything I can help out with?

[cayasso]

The changes mentioned above are completed empty, isEmpty and clear are new methods in adapter.js in [email protected] which had a major refactoring for compatibility with [email protected] now that major changes are over I will continue on this effort one think would be to make primus-redis rooms adapter by @neoziro compatible with these latest changes. I had a working primus-redis version before but I deleted it by accident and now I have to start all over again :-(.

[gregberge]

Ok it's good, perhaps I can help you ?

For me the main problem was to make primus-redis compatible with primus-multiplex, primus rooms already works with primus-redis.

[gregberge]

I have just released a new version of primus-redis, it's now called primus-cluster. It's compatible with primus v2.0+, primus-rooms, primus-emitter, and primus-resource. primus-multiplex is still no supported, may be you can take a look to add support.

[cayasso]

@neoziro that is awesome! I will take a look to bring support to multiplex.

[gregberge]

@aslakhellesoy thanks, you can contribute to primus-ckuster if you want :)

[fabien]

@cayasso any updates on this? I'm interested in multiplex + redis / cluster handling. Thanks!