Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Vue starter app #1052

Closed
14 tasks done
ethanWallace opened this issue Jul 29, 2024 · 4 comments
Closed
14 tasks done

Create Vue starter app #1052

ethanWallace opened this issue Jul 29, 2024 · 4 comments
Assignees
Labels
Groomed Issues that have been refined and are ready to be worked on.

Comments

@ethanWallace
Copy link
Collaborator

ethanWallace commented Jul 29, 2024

A starter app in the Vue framework to allow developers a quick and easy start using the GC Design System in the Vue framework.

Acceptance criteria:

  • Government of Canada branding (header/footer)
  • I18N (English/French)
  • Intro page
  • Report a bug page
  • Basic rendering end-to-end tests (app renders)

Done when

  • English pages
  • French pages
  • Merged into gcds-examples repo under starter-app directory
  • e2e tests that verify the app has:
    • Rendered
    • Page navigation
  • All text have equivalents in french and english
    • French
    • English
@adorayi adorayi added the Groomed Issues that have been refined and are ready to be worked on. label Jul 29, 2024
@adorayi adorayi added this to the Q2 2024 Deliverables milestone Jul 29, 2024
@daine daine assigned daine and unassigned ethanWallace Jul 30, 2024
@daine
Copy link
Collaborator

daine commented Aug 14, 2024

Did some prep work to visualize this while working on the vue starter app: https://miro.com/app/board/uXjVKsYgVU8=/?moveToWidget=3458764596479395624&cot=14

Didn't get to finish it today, but I was in the middle of adding the following pieces:

Here is the branch:
https://github.com/cds-snc/gcds-examples/tree/feat/vue-starter-app

Here is the folder inside the branch:
https://github.com/cds-snc/gcds-examples/tree/feat/vue-starter-app/starter-apps/vue/vue-template

@adorayi
Copy link
Contributor

adorayi commented Oct 1, 2024

Code review still pending.
Requires content review and then translation + bilingual review.

@daine
Copy link
Collaborator

daine commented Oct 4, 2024

This should be good to go for translation and bilingual review.

Here is all the text that needs to be reviewed and have translation:
https://github.com/cds-snc/gcds-examples/blob/feat/vue-starter-app/starter-apps/vue/vue-template/src/i18n/en.js

Here is the french file (please note it needs a full review): https://github.com/cds-snc/gcds-examples/blob/feat/vue-starter-app/starter-apps/vue/vue-template/src/i18n/en.js

Here are the routing paths in English and french, which will need a review as well. They are the URLs that show on the browser address bar:
https://github.com/cds-snc/gcds-examples/pull/21/files#diff-3e884d1153e9232f30d2b52c0f84a7138454dd8473550b72a350a325b03f2825R9-R27

Here is the README for the codebase: https://github.com/cds-snc/gcds-examples/pull/21/files?short_path=48f4f14#diff-48f4f1431758bd64e7b49c67c3fc6cafe71081260abe68de36bfb66eb21dc3c9

List of what is needed:

  • Content review for text that appears on all the pages
  • Corresponding french content for text the appears on all the pages
  • Routing path URLS need french review and translation
  • Technical README needs french translation

@SmartMouthWords would you like to have a separate ticket for the content review? Let me know, I know it's a lot.

@daine
Copy link
Collaborator

daine commented Oct 21, 2024

Moving the content pieces into another ticket:

  • Content review (English content)
  • Bilingual review and french content

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Groomed Issues that have been refined and are ready to be worked on.
Projects
None yet
Development

No branches or pull requests

3 participants