Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design: Heading to align with coded heading #1094

Closed
18 tasks done
realdylanzheng opened this issue Aug 20, 2024 · 3 comments
Closed
18 tasks done

Design: Heading to align with coded heading #1094

realdylanzheng opened this issue Aug 20, 2024 · 3 comments
Assignees
@nmakuch
Labels
Groomed Issues that have been refined and are ready to be worked on.

Comments

@realdylanzheng
Copy link

realdylanzheng commented Aug 20, 2024 •
edited by nmakuch
Loading

The coded Heading has margin-top and margin-bottom values which the Figma component does not have. Add spacing to Figma Headings to mimic margins so they appear consistent with coded outputs.

Acceptance criteria

  • All heading levels must have margin-bottom: 400
  • h1 must have margin-top: 0
  • h2-h3 must have margin-top: 500
  • Heading must have boolean property: Vertical margins?
  • Poster to recommend space component for margin values outside of the default
  • Updates are done in EN and in FR library

Done when

  • Reviewed by designers
  • Reviewed by developers
  • EN component is merged and published
  • FR component is merged and published
  • Poster content design review
  • Poster translations
  • EN poster merged and published
  • FR poster merged and published

Deliverables

  • EN component in Figma
  • FR component in Figma
  • EN poster in Figma
  • FR postert in Figma

Dev impact

None
@realdylanzheng realdylanzheng added the For Grooming Issues with this label will be prioritized in the next team grooming session and likely next sprint label Aug 20, 2024
@nmakuch nmakuch self-assigned this Aug 21, 2024
@adorayi adorayi added Groomed Issues that have been refined and are ready to be worked on. and removed For Grooming Issues with this label will be prioritized in the next team grooming session and likely next sprint labels Aug 22, 2024
@nmakuch
Copy link

nmakuch commented Aug 30, 2024

EN updates in branch for review:
https://www.figma.com/design/mh2maMG2NBtk41k1O1UGHV/branch/omJPAgCAbhtOrk6hVH3zi1/GC-Design-System?node-id=9439-684&node-type=FRAME&t=yCdsQLXrViMXPwAG-0

@nmakuch
Copy link

nmakuch commented Aug 30, 2024

FR updates in branch for review:
https://www.figma.com/design/o4SguSZdar2CCFzSkWNrmB/branch/qPi2DnQiMXDTY955DnMqz3/Syst%C3%A8me-de-design-GC?node-id=121-15628&node-type=FRAME&t=ImVDu8s57JyJSIwK-0

@nmakuch
Copy link

nmakuch commented Sep 10, 2024 •
edited
Loading

UPDATE
Matilde has done a content review and poster content has been sent to translations

@adorayi adorayi closed this as completed Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nmakuch nmakuch

Labels
Groomed Issues that have been refined and are ready to be worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@realdylanzheng @nmakuch @adorayi