Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design: Text to align with coded Text #1098

Closed
16 tasks done
adorayi opened this issue Aug 22, 2024 · 4 comments
Closed
16 tasks done

Design: Text to align with coded Text #1098

adorayi opened this issue Aug 22, 2024 · 4 comments
Assignees
@realdylanzheng @nmakuch
Labels
Groomed Issues that have been refined and are ready to be worked on.

Comments

@adorayi
Copy link
Contributor

adorayi commented Aug 22, 2024 •
edited by nmakuch
Loading

The coded Heading has margin-top and margin-bottom values which the Figma component does not have. Add spacing to Figma Headings to mimic margins so they appear consistent with coded outputs.

Acceptance criteria

  • All variants should have margin-bottom: 400
  • Text component must have boolean property: Vertical margins?
  • Poster to recommend space component for margin values outside of the default
  • Work done in EN and in FR

Done when

  • Reviewed by designers
  • Reviewed by developers
  • EN component is merged and published
  • FR component is merged and published
  • Poster content design review
  • Poster translations
  • EN poster merged and published
  • FR poster merged and published

Deliverables

  • EN component in Figma
  • FR component in Figma
  • EN poster in Figma
  • FR postert in Figma

Dev impact

None
@adorayi adorayi added the Groomed Issues that have been refined and are ready to be worked on. label Aug 22, 2024
@adorayi adorayi changed the title Copy of Design: Heading to align with coded heading Design: Text to align with coded Text Aug 27, 2024
@adorayi adorayi added For Grooming Issues with this label will be prioritized in the next team grooming session and likely next sprint and removed Groomed Issues that have been refined and are ready to be worked on. labels Aug 27, 2024
@nmakuch
Copy link

nmakuch commented Aug 30, 2024

EN updates in branch for review:
https://www.figma.com/design/mh2maMG2NBtk41k1O1UGHV/branch/omJPAgCAbhtOrk6hVH3zi1/GC-Design-System?node-id=10053-348&node-type=CANVAS&t=yCdsQLXrViMXPwAG-0

@nmakuch
Copy link

nmakuch commented Aug 30, 2024

FR updates in branch for review:
https://www.figma.com/design/o4SguSZdar2CCFzSkWNrmB/branch/qPi2DnQiMXDTY955DnMqz3/Syst%C3%A8me-de-design-GC?node-id=114-3353&node-type=CANVAS&t=ImVDu8s57JyJSIwK-0

@nmakuch nmakuch added Groomed Issues that have been refined and are ready to be worked on. and removed For Grooming Issues with this label will be prioritized in the next team grooming session and likely next sprint labels Sep 3, 2024
@adorayi
Copy link
Contributor Author

adorayi commented Sep 9, 2024

Figma updates done, poster work in EN done and awaiting review, translation to be started.

@nmakuch
Copy link

nmakuch commented Sep 10, 2024 •
edited
Loading

UPDATE
Matilde has done a content review and poster content has been sent to translations

@adorayi adorayi closed this as completed Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@realdylanzheng realdylanzheng

@nmakuch nmakuch

Labels
Groomed Issues that have been refined and are ready to be worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@realdylanzheng @nmakuch @adorayi