Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design: Reduce white space in Header #1316

Open
11 tasks
adorayi opened this issue Jan 9, 2025 · 4 comments
Open
11 tasks

Design: Reduce white space in Header #1316

adorayi opened this issue Jan 9, 2025 · 4 comments
Assignees
@realdylanzheng
Labels
development Development tasks For Grooming Issues with this label will be prioritized in the next team grooming session and likely next sprint Groomed Issues that have been refined and are ready to be worked on. High Priority | Haute priorité New | Nouveau New card, needs to be groomed

Comments

@adorayi
Copy link
Contributor

adorayi commented Jan 9, 2025 •
edited by realdylanzheng
Loading

User story

As an enduser...
I want to have the white space reduced...
so that more content can be fit above the fold of the page.

Acceptance criteria

  • White space is reduced in accordance with the component grid.
    • Margins top, bottom are reduced
    • Interior padding is reduced

Definition of Done / Outcomes

  • Reviewed by a designer
  • Reviewed by DTO
  • EN component is ready for merge
  • FR Component is ready for merge
  • Update/Create requirements doc

Deliverables

  • EN component
  • FR component
  • Requirements doc

Dev impact

Yes

Screen captures

Add here any context and or link that could be useful to understand the work
Screenshot 2024-12-30 at 9.20.26 AM.png

Screenshot 2024-12-12 at 1.03.18 AM.png

Screenshot 2024-12-12 at 1.05.11 AM.png

. 🚫 Out of scope
_ If possible, give precisions on what is not part of this work_
@adorayi adorayi added the New | Nouveau New card, needs to be groomed label Jan 9, 2025
@SmartMouthWords
Copy link
Collaborator

This may be fixed with the breadcrumb update. Check once changes from #1270 and #1204 are in and applied to the site.

@realdylanzheng
Copy link

realdylanzheng commented Jan 10, 2025 •
edited
Loading

@SmartMouthWords while vertical spacing has been reduced in the breadcrumbs when wrapped it won't however reduce the overall top and bottom margins of the header. The header component still needs to be tweaked to meet the acceptance criteria of this ticket.

@realdylanzheng realdylanzheng self-assigned this Jan 10, 2025
@SmartMouthWords
Copy link
Collaborator

Screenshot 2025-01-10 at 4.39.20 PM.png

@SmartMouthWords SmartMouthWords added Groomed Issues that have been refined and are ready to be worked on. For Grooming Issues with this label will be prioritized in the next team grooming session and likely next sprint labels Jan 10, 2025
@SmartMouthWords
Copy link
Collaborator

@realdylanzheng Thanks. Could you add relevant details this card?

@realdylanzheng realdylanzheng changed the title Consider reducing the white space below in certain areas of the header Design: Reduce white space in Header Jan 15, 2025
@adorayi adorayi removed the For Grooming Issues with this label will be prioritized in the next team grooming session and likely next sprint label Jan 15, 2025
@daine daine added the development Development tasks label Jan 15, 2025
@adorayi adorayi added For Grooming Issues with this label will be prioritized in the next team grooming session and likely next sprint High Priority | Haute priorité labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@realdylanzheng realdylanzheng

Labels
development Development tasks For Grooming Issues with this label will be prioritized in the next team grooming session and likely next sprint Groomed Issues that have been refined and are ready to be worked on. High Priority | Haute priorité New | Nouveau New card, needs to be groomed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@daine @realdylanzheng @SmartMouthWords @adorayi