Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev: Align Language Toggle with canada.ca #1333

Open
10 tasks
realdylanzheng opened this issue Jan 20, 2025 · 1 comment
Open
10 tasks

Dev: Align Language Toggle with canada.ca #1333

realdylanzheng opened this issue Jan 20, 2025 · 1 comment
Labels
For Grooming Issues with this label will be prioritized in the next team grooming session and likely next sprint High Priority | Haute priorité

Comments

@realdylanzheng
Copy link

realdylanzheng commented Jan 20, 2025 •
edited by daine
Loading

📇 User Story or Summary

As a developer, I want the font size on the link component within the language toggle component to render at a size of 16px to complete the alignment work with Canada.ca

✅ Definition of Done / Outcomes

  • Done when a new component token exists for the language toggle link
  • Done when a PR is reviewed and approved on the tokens repository
  • Done when the PR on the tokens repository is merged and released
  • Done when a PR on the components repository is approved and ready to merge, but not yet merged
  • Done when PR on the components repository has been reviewed by at least 1 dev
  • Done when tests are written and passing

📜 Acceptance criteria

  • Language toggle link font size is set to 16px (1rem) to align with Canada.ca
  • There is a new component token for the language toggle (or header component)
  • PR on the components repository needs to be reviewed by at least 1 designer
  • PR on the components repository, while approved, should not yet be merged
@adorayi adorayi added For Grooming Issues with this label will be prioritized in the next team grooming session and likely next sprint High Priority | Haute priorité labels Jan 22, 2025
@adorayi
Copy link
Contributor

adorayi commented Jan 22, 2025 •
edited
Loading

Consider adding an acceptance criteria for font change to Lato, pending decision after meeting with DTO.

  • Decision: font should be noto with semi bold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
For Grooming Issues with this label will be prioritized in the next team grooming session and likely next sprint High Priority | Haute priorité
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@realdylanzheng @adorayi