Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development of the Link component #506

Closed
13 of 24 tasks
adorayi opened this issue Sep 20, 2023 · 2 comments · Fixed by cds-snc/gcds-components#305
Closed
13 of 24 tasks

Development of the Link component #506

adorayi opened this issue Sep 20, 2023 · 2 comments · Fixed by cds-snc/gcds-components#305
Assignees

Comments

@adorayi
Copy link
Contributor

adorayi commented Sep 20, 2023

Develop on component branch, push to staging and push to prod when approved.

Acceptance Criteria:

  • Component kickoff
  • Sync with Design
  • Requirements documentation
  • Requirements doc: Consider edge cases
  • Requirements doc: Describe component properties
  • Review of requirements doc
  • Develop the component according to the requirements doc and design specs
  • Add component to storybook
  • Write draft of dev guidance
  • Sync dev properties with Figma properties (design + dev) (Figma component)
  • Handoff from draft dev guidance to documentation author/lead
  • WCAG Goal can be completed using a screen reader.
  • WCAG Visual elements observe color contrast requirements.
  • WCAG Manual accessibility testing meets WCAG 2.1 AA requirements.
  • Provides equal service in French and English.
  • Comparison with official policy, documented reasons for deviation if any
  • Final sync with Design
  • Policy review
  • Code review
  • After PR approval, merge component to staging
  • Review from Design
  • Review from Policy
  • Note: reviews could be done on Storybook staging
  • Push to prod
@daine daine self-assigned this Oct 11, 2023
@samburtonCDS
Copy link

Policy considerations

MANDATORY COLOURS
The Canada.ca design system specifies mandatory colours for link text, selected links, and visited links.

The GCDS team confirms the intention to comply with those mandatory colours in the GCDS policy review.

Mandatory colours are:

  • default link: #2b4380
  • selected link (on hover or focus): #0535d2
  • visited link: #7834bc

There are no other mandatory elements related to this component in the Canada.ca design system.

RECOMMENDATION: DOCUMENT DECISIONS
I recommend that we proactively document significant design decisions (eg. why we use icons to identify with certain types of links and how we chose the images) so we can easily explain our recommendations to potential users.

  • This may already be part of your workflow, in which case you can ignore this suggestion :)
  • If this would be a new and/or additional task, I’m happy to help!

Resources from canada.ca design system that may be useful to review

Overall, the canada.ca design system does not use or recommend icons to designate certain kinds of links.

@daine
Copy link
Collaborator

daine commented Oct 19, 2023

I have a PR open here

At the moment, here's what the different links would look like:
Screenshot 2023-10-19 at 10 26 20 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants