-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[suggestion] Option to disable autochange country when typing #269
Comments
What would be the expected behavior ? What would it display when you do +1 ? |
Just continue displaying +1, without switching countries. |
What do you think about this :
|
I would not like to give the opportunity to change the country if it is not on the list of available ones. I would like to be able to strictly limit the input of unsupported numbers so that the user immediately understands that the application is not available in his country. I thought that's what the list of |
Any updates on this issue? |
I'm not sure about this, it seems counter intuitive from an UX standpoint. I proposed before that it would change the country with an invalid message and not display the country in the list of countries. Or maybe something else entirely.
Can you implement it ? Let's land on a design for the first point of this comment first though. |
What then is the point of the If you strictly prohibit changing the country when typing a prefix, if it is not in the list of allowed ones, then this can become breaking changes, which is not good. Therefore, I would suggest introducing a special flag for this. For example
I can try it when I have free time (maybe this month). |
It does not let the option to the user to select that country in the list
Yes currently that's how it works, and it's not perfect. I'm still of the opinion that just writing |
I agree that displaying an error is a good option, but I wouldn’t want the country’s flag to change at the same time, and would simply leave the input field as is, but with an input error. |
Maybe we could disable the autochange for all countries (not just invalid ones), but that seems like a really niche use case ? Let me explain why I think having a different behavior for valid and invalid countries would lead to bad UX: We both agree that feedback should be conveyed to the user when he tries to enter an invalid country, an error message should therefor be shown, we agree on that part. If that's the case, then the input is going to be in an invalid state whether or not the flag is changed. I'm arguing that the not changing the flag will be confusing for the following reasons:
So all in all I agree that a message should be shown but I believe there is value in changing the flag so the user can have feedback about where the country code he entered originates from. |
Hi is it done added? for this feature |
I have set up a list of supported countries in the
CountrySelectorNavigator
(by passing aList<IsoCode>
tocountries
parameter ofCountrySelectorNavigator
constructor ) and want to be able to enter a phone number for supported countries only. But if I start entering the phone number prefix of another country that I do not have in the list, it automatically changes to it.Here is a video with an example of reproducing the bug.
Is is possible to disable now?
The text was updated successfully, but these errors were encountered: