Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for Handle migrated celo transactions PR #151

Open
piersy opened this issue Jun 21, 2024 · 0 comments · May be fixed by #306
Open

Add test for Handle migrated celo transactions PR #151

piersy opened this issue Jun 21, 2024 · 0 comments · May be fixed by #306
Assignees
@Kourin1996
Labels
type:bug Something isn't working type:tests
Milestone
5 - Celo MVP Mainnet

Comments

@piersy
Copy link

piersy commented Jun 21, 2024 •
edited
Loading

Add tests for code added in

We probably want tests for rlp & json encode/decode for CeloDynamicFeeTx, CeloDynamicFeeTxV2 & LegacyTx. Ensuring we try the encode/decode for the LegacyTx with the CeloLegacy field as both true and false.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kourin1996 Kourin1996

Labels
type:bug Something isn't working type:tests
Projects
None yet
Milestone
5 - Celo MVP Mainnet
Development

Successfully merging a pull request may close this issue.

Add unit tests for JSON and RLP encoding/decoding of Celo Transactions celo-org/op-geth
3 participants
@lvpeschke @piersy @Kourin1996