Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close button style is broken with Bootstrap 5. #83

Open
VinVinMa opened this issue Jan 25, 2023 · 3 comments
Open

Close button style is broken with Bootstrap 5. #83

VinVinMa opened this issue Jan 25, 2023 · 3 comments

Comments

@VinVinMa
Copy link

Hi,

As a breaking change in Bootstrap 5. The 'x' will not be rendered as button and displayed at the wrong side.

https://getbootstrap.com/docs/5.0/migration/#close-button

Cheers,

Vincent

@chadly
Copy link
Owner

chadly commented Mar 16, 2023

I don't really use this library anymore and don't have the energy to put development time into it.

I'm happy to merge a PR to fix issues like this though, if you are willing to fix it.

@BudgieInWA
Copy link

The change is relatively simple, but would break compatibility with earlier versions of Bootstrap.

@chadly do you have a preferred mechanism for supporting both Bootstrap flavours? Different component names? Different import paths? New major version on NPM (with the idea of maintaining both major versions). New npm package react-bs5-notifier built from the same repo, or a fork?

@chadly
Copy link
Owner

chadly commented Jul 27, 2023

definitely not going to manage multiple versions. but I think doing a major version upgrade with support for newer bootstrap versions makes sense going forward.

in other words, forget about backwards compatibility 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants