Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose less awkward Files type in Report struct #741

Open
egibs opened this issue Dec 30, 2024 · 1 comment
Open

Expose less awkward Files type in Report struct #741

egibs opened this issue Dec 30, 2024 · 1 comment
Assignees
@egibs

Comments

@egibs
Copy link
Member

egibs commented Dec 30, 2024

We should store Files as a map[string]*FileReport type rather than sync.Map in the Report struct. We can use an intermediary struct for the concurrent operations and then build the final report with the more friendly type.

I already have working code for this and should have the PR up soon.
@egibs egibs self-assigned this Dec 30, 2024
@egibs egibs changed the title Expose less awkward files type in Report struct Expose less awkward Files type in Report struct Dec 30, 2024
@egibs
Copy link
Member Author

egibs commented Dec 31, 2024

It probably makes sense to land this after the #734 refactor since that will change the layout of scan.go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@egibs egibs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@egibs